[fix] Correct a pair of "when you discard one or more X cards" triggered abilities#14550
Merged
muz merged 2 commits intoJun 14, 2026
Merged
Conversation
muz
force-pushed
the
DiscardOneOrMoreCardsTriggeredAbility_filter
branch
from
67063ef to
d4b7ca6
Compare
Contributor
Author
|
Rebased and amended the git history. We can use the Ability changes introduced in #14335 now so that these cards are implemented correctly. |
xenohedron
approved these changes
Jun 1, 2026
xenohedron
left a comment
xenohedron
left a comment
Contributor
There was a problem hiding this comment.
I don't think this was actually bugged in practice due to the "triggers only once each turn", but nice to align it.
| private static final FilterCard filter = new FilterArtifactCard("one or more artifact cards"); | ||
|
|
||
| public MishraExcavationProdigy(UUID ownerId, CardSetInfo setInfo) { | ||
| public MishraExcavationProdigy(UUID ownerId, CardSetInfo setInfo) { |
Member
|
@xenohedron not for PR, but there are possible many other places to check for wrongly usage one or more triggers, search code by 
Some of it uses weird workarounds like But some of it do nothing and can trigger multiple times. Must be fixed by group/batch events or by another ways (if really buggy). |
muz
force-pushed
the
DiscardOneOrMoreCardsTriggeredAbility_filter
branch
from
d4b7ca6 to
3b2f952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be merged until after #14335 is complete.
DiscardCardControllerTriggeredAbilitywhereDiscardOneOrMoreCardsTriggeredAbilityshould be usedDiscardOneOrMoreCardsTriggeredAbilitywas updated to support this in a backwards compatible manner